Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only collapse layer control if collapsed: true #5131

Merged
merged 2 commits into from Nov 23, 2016

Conversation

perliedman
Copy link
Member

Fixes regression caused by #5087. Close #5126.

Copy link
Member

@IvanSanchez IvanSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@IvanSanchez IvanSanchez merged commit 2253672 into master Nov 23, 2016
jieter added a commit to jieter/Leaflet that referenced this pull request Dec 6, 2016
@IvanSanchez IvanSanchez deleted the fix-layers-control-collapse branch December 6, 2016 10:43
@jieter
Copy link
Contributor

jieter commented Dec 6, 2016

It still seems to have different behaviour: moving the mouse over the control and then back to the map makes the control collapse, while before it stayed open with collapsed: false

playground with leaflet 1.0.2 (collapses after hovering control)
playground with leaflet 1.0.0 (not collapsing, expected behaviour)

@IvanSanchez
Copy link
Member

@jieter The behaviour in master after this PR should be the same as 1.0.0.

@jieter
Copy link
Contributor

jieter commented Dec 6, 2016

Ah, OK, the changelog description tricked me into thinking that this is part of 1.0.2, which it is apparently not.

DiogoMCampos pushed a commit to DiogoMCampos/Leaflet that referenced this pull request Dec 18, 2016
DiogoMCampos pushed a commit to DiogoMCampos/Leaflet that referenced this pull request Dec 18, 2016
perliedman pushed a commit that referenced this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants