Change dependencies to peerDependencies #5142

Merged
merged 1 commit into from Nov 24, 2016

Projects

None yet

5 participants

@Ralf8686
Contributor

If I some plugin include leaflet to dependencies and I have local version leaflet, then I have two version - leaflet from plugin and my.

@Ralf8686 Ralf8686 Change dependencies to peerDependencies
If I some plugin include leaflet to dependencies and I have local version leaflet, then I have two version - leaflet from plugin and my.
eeedd73
@IvanSanchez IvanSanchez merged commit 1883620 into Leaflet:master Nov 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@theashyster
Contributor

I am confused now - so this was a wrong thing to do? #4534

@semone semone referenced this pull request in kartena/Proj4Leaflet Nov 24, 2016
Open

Change dependencies to peerDependencies #127

@semone
semone commented Nov 24, 2016

Plus one on the confusion

@theashyster
Contributor

I would suggest the same thing as @hyperknot in #4534
If Leaflet is required for building a plugin, it should be specified in devDependencies, not peer.

@DiogoMCampos DiogoMCampos added a commit to DiogoMCampos/Leaflet that referenced this pull request Dec 18, 2016
@Ralf8686 @DiogoMCampos Ralf8686 + DiogoMCampos Docs: peerDependencies in plugins guide (#5142)
If I some plugin include leaflet to dependencies and I have local version leaflet, then I have two version - leaflet from plugin and my.
d7a138f
@DiogoMCampos DiogoMCampos added a commit to DiogoMCampos/Leaflet that referenced this pull request Dec 18, 2016
@Ralf8686 @DiogoMCampos Ralf8686 + DiogoMCampos Docs: peerDependencies in plugins guide (#5142)
If I some plugin include leaflet to dependencies and I have local version leaflet, then I have two version - leaflet from plugin and my.
e95ae28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment