Control position extend #5554
Closed
Control position extend #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do we go about legacy browsers that don't support transform here? Is there a fallback in behavior? |
|
@mourner hm, yes, you're right, this will not work in IE < 9 if I understand correctly. We'll have to bring out the annoying IE workarounds once again, I guess. |
3 tasks
|
Closing in favor of #8358, to discuss this thoroughly first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #5264.
Vertical and horizontal center is added with the new control positions
topcenter,leftcenter,rightcenter,bottomcenterandcenter(vertical and horizontal center).This is mostly @yigityuce's work.
After some discussion, the consensus seems to be that the using the CSS terminology "middle" for vertical center is confusing, so we now use "center" for horizontal as well as vertical. We also happen to use the same terminology as another map library (thanks @gassc for this hint).