Make sure TileLayer load event is fired #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded. However, the previous code only took into account successful tile loads. It is legitimate for a tile load to cause an error - you might be zoomed out on a map and are pulling a non-existent tile (especially on indoors maps). This patch takes into account both successful and unsuccessful tile loads.
mourner
added a commit
that referenced
this pull request
May 15, 2012
Make sure TileLayer load event is fired
|
You're right, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load event for a tile layer is only fired after all tiles are loaded. However, the previous code only took into account successful tile loads. It is legitimate for a tile load to cause an error - you might be zoomed out on a map and are pulling a non-existent tiles around the edge (especially on indoors maps). This patch takes into account both successful and unsuccessful tile loads.