Trigger popupopen/close on markers too. #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull, will be merged! Regarding the logic spread: but initially the responsibility was partially put on L.Map to close previous popups when opening a new one, but I agree the code should be refactored so that maximum logic is on the L.Popup side. |
|
I will try to do this refactoring in this PR |
|
Thanks, no need I think, I planned to merge this pull (and another popup-events-related one) into a separate branch and do some refactoring myself. |
|
@mourner Vladimir, any news on |
ghost
assigned
|
@Koc sorry for not getting back to you earlier. Finally got this merged with some modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more thing: I cann't understand why popup-opening/closing logic are spreaded between
L.PopupandL.Map.