Skip to content

Conversation

danzel
Copy link
Member

@danzel danzel commented Jun 25, 2012

This gets the marker zoom animations going in IE 10.
The map tiles zoom animation is a bit wonky, I'm not going to fix it at this stage as it works correctly in all other browsers. Will re-test when IE 10 is closer to release.

Not sure if multi-touch support will work as I don't have a device.
Tested with Release Preview in a VirtualBox VM.

…ualBox VM). Not sure if multi-touch support will work as I don't have a device.
@danzel
Copy link
Member Author

danzel commented Jun 25, 2012

Oh yeah, I've tested ie9, nothing changes there as expected :)

mourner added a commit that referenced this pull request Jun 25, 2012
Minor fixups for IE 10 support
@mourner mourner merged commit 1a598fe into Leaflet:master Jun 25, 2012
@mourner
Copy link
Member

mourner commented Jun 25, 2012

Thanks! Since you have an IE10 set up in VM, could you also check #650?

@RileySpiller
Copy link

Thanks! Zooming looks good enough for now but panning went away.

@danzel
Copy link
Member Author

danzel commented Jul 11, 2012

@RileySpiller Panning and inertial panning seem to work fine in my VM. Are you running on a touch device or something?

Just noticed some of the opacity (The mid-markers on vector/editable.html) isn't working, might be my VM. I'll take a look now.

@danzel
Copy link
Member Author

danzel commented Jul 11, 2012

Mourner is on to it, Opacity fix merged :)

@RileySpiller
Copy link

Hmm... maybe I didn't grab the latest build. I'll try again. I've got it embeded in a Win8 Metro app... so, yes, it will be for touch eventually but I'm using mouse for now. Metro apps generally run exactly as they would in the IE10 browser with a few exceptions.

@RileySpiller
Copy link

Tried it again... here's a video of what I see: http://rileyspiller.com/leaflet.mov. I'm not able to pan. I can, strangely, pan if I grab it from the zoom control. You didn't experience this in IE10?

@danzel
Copy link
Member Author

danzel commented Jul 18, 2012

That is weird indeed!

Try this:
http://danzel.github.com/Leaflet/debug/vector/vector-canvas.html

I've just verified it works in my IE Metro in a Win 8 VM in VirtualBox.
I can pan the map with mouse clicks etc, zoom wheel zoom works, double click zoom works etc.

Are you running that on your desktop? Mouse might be coming through as touch events or something weird.

@RileySpiller
Copy link

It's working. I'd made a silly error and had an invisible element on top of the map that was stealing the click events. It's working fine now. Thanks for your help!

@grahamj
Copy link

grahamj commented Aug 3, 2012

Hey all,

Thanks for your work with Metro so far! I'm writing an internal app here and embedding Leaflet too. Devving on an Asus EP121 touch tablet. It generally works well except that double-click zooming is a bit wonky (seems like it jump-pans a bit then pans and zooms to center) and no multitouch zoom.

danzel, it sounds like you're seeing the same zoom issue. I know it's probably not a priority for most people but I need to have it fixed! Any chance you can point me in the right direction for that? I'm going to see about fixing the multitouch issue myself.

@grahamj
Copy link

grahamj commented Aug 3, 2012

Also, when I first ran my app I got errors about directly accessing elements' content with innerHTML so I had to wrap all outgoing content in window.toStaticHTML()

Did anyone else run into this? I'm wondering if maybe I should submit my changes here, though I'm kind of a git newb.

@grahamj
Copy link

grahamj commented Aug 3, 2012

@RileySpiller
Copy link

@grahamj Thanks for posting. I'd love to get those animations fixed also.

I got around the dynamic content blockages in Metro by creating an iframe to handle the server communication (I've got search box and whatnot). The html file in my iframe is referenced through the ms-appx-web:// sceme (more info: http://msdn.microsoft.com/en-us/library/windows/apps/hh781215.aspx). I pass any important info back to app with a Javascript postMessage. Lemme know if you have any questions.

@grahamj
Copy link

grahamj commented Aug 8, 2012

Ah ok. I considered that but in my application everything has to be part of the app. So far so good!

@danzel danzel changed the title Minor fixups for IE 10 support Minor fixups for IE 10 support Apr 1, 2014
@Malvoz Malvoz added the ie Internet Explorer label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ie Internet Explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants