DomUtil removeClass space handling. #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Class in stead of manual class manimulation in Map.ZoomAnimation
|
You're right! I was going to do that too (did the same recently for |
mourner
added a commit
that referenced
this pull request
Jul 5, 2012
DomUtil removeClass space handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting the DOM in Chrome I noticed spaces being added to the class attribute of the
leaflet-map-pane-div. The regexp to remove spaces after removing a class in removeClass only removed spaces in the head, added a second case to the regexp to remove spaces at the tail.Also use DomUtil.addClass in Map.ZoomAnimations.js instead of manual class manipulation. When writing this comment, I just grepped for "className +=" and found quite some (19) other occurrences... If you like, I can change them too.