New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Github action to update license year automatically #7893
Added Github action to update license year automatically #7893
Conversation
Have you checked if it works correctly? The Lines 3 to 4 in e9bc859
|
Yes, this is a manual run of the Github action: https://github.com/marcoschicote/Leaflet/pull/2/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good way to automate a trivial but annoying task. However I wonder if keeping this workflow file maintained might end up being more work than manually adding a commit for the copyright dates.
If that were to be the case it's just a matter of deleting the Github action. Hopefully this will not happen :) |
Appreciate the contribution, but personally I don't think non-essential actions that need to happen once a year need automation — it adds complexity and a dependency on one more third-party GH action. Also, there are more places where the year could be updated (e.g. at the bottom of the website). |
OK.man
…On Sat, 8 Jan 2022, 22:00 Vladimir Agafonkin, ***@***.***> wrote:
Appreciate the contribution, but personally I don't think non-essential
actions that need to happen once a year need automation — it adds
complexity and a dependency on one more third-party GH action. Also, there
are more places where the year could be updated (e.g. at the bottom of the
website).
—
Reply to this email directly, view it on GitHub
<#7893 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS2UXSGTUQOIZ23RBZGSTCTUVCXW3ANCNFSM5LOUVAOQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Did not know the year was also included in the footer. Shouldn't we use |
I close this PR because of @mourner and @jonkoops concerns. @marcoschicote would be very nice to see a PR from you which updates the |
Will do! |
IMHO we could just add |
I created #7907 which uses a jekyll command instead of JavaScript |
Fixes #7891