Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github action to update license year automatically #7893

Conversation

marcoschicote
Copy link

Fixes #7891

@Falke-Design
Copy link
Member

Have you checked if it works correctly? The LICENSE.md file contains two date ranges:

Leaflet/LICENSE

Lines 3 to 4 in e9bc859

Copyright (c) 2010-2021, Vladimir Agafonkin
Copyright (c) 2010-2011, CloudMade

@marcoschicote
Copy link
Author

Have you checked if it works correctly? The LICENSE.md file contains two date ranges:

Leaflet/LICENSE

Lines 3 to 4 in e9bc859

Copyright (c) 2010-2021, Vladimir Agafonkin
Copyright (c) 2010-2011, CloudMade

Yes, this is a manual run of the Github action: https://github.com/marcoschicote/Leaflet/pull/2/files

Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good way to automate a trivial but annoying task. However I wonder if keeping this workflow file maintained might end up being more work than manually adding a commit for the copyright dates.

@marcoschicote
Copy link
Author

This seems like a good way to automate a trivial but annoying task. However I wonder if keeping this workflow file maintained might end up being more work than manually adding a commit for the copyright dates.

If that were to be the case it's just a matter of deleting the Github action. Hopefully this will not happen :)

@mourner
Copy link
Member

mourner commented Jan 8, 2022

Appreciate the contribution, but personally I don't think non-essential actions that need to happen once a year need automation — it adds complexity and a dependency on one more third-party GH action. Also, there are more places where the year could be updated (e.g. at the bottom of the website).

@lordt4ever
Copy link

lordt4ever commented Jan 8, 2022 via email

@marcoschicote
Copy link
Author

Appreciate the contribution, but personally I don't think non-essential actions that need to happen once a year need automation — it adds complexity and a dependency on one more third-party GH action. Also, there are more places where the year could be updated (e.g. at the bottom of the website).

Did not know the year was also included in the footer. Shouldn't we use new Date().getFullYear() there?

@Falke-Design
Copy link
Member

I close this PR because of @mourner and @jonkoops concerns.

@marcoschicote would be very nice to see a PR from you which updates the LICENSE.md and the footer 😊

@marcoschicote
Copy link
Author

I close this PR because of @mourner and @jonkoops concerns.

@marcoschicote would be very nice to see a PR from you which updates the LICENSE.md and the footer 😊

Will do!
But what's your opinion on how to fix the footer? Should we use new Date().getFullYear() or hardcode the year?

@jonkoops
Copy link
Collaborator

IMHO we could just add <script>document.write(new Date().getFullYear())</script> to the footer.

@Falke-Design
Copy link
Member

I created #7907 which uses a jekyll command instead of JavaScript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License yearly update
5 participants