Skip to content

Conversation

danzel
Copy link
Member

@danzel danzel commented Aug 1, 2012

When removing a marker from a FeatureGroup, only remove the popup if it was put there by the FeatureGroup.

Refs danzel/Leaflet.markercluster#24

…it was put there by the FeatureGroup.

Refs danzel/Leaflet.markercluster#24
@blowsie
Copy link

blowsie commented Aug 1, 2012

I found the pop ups unreliable on both spiderfied and unspidefied markers.

See this video I made regarding the reliability of spiderfied markers.
https://dl.dropbox.com/u/14037764/Development/stackoverflow/leaflet/spierfied/spiderfied-pop-ups-reliability.html

At the time of posting unspiderfied markers don't work at all for me.

@mourner
Copy link
Member

mourner commented Aug 1, 2012

Do you mean that it's unreliable even with this pull merged in?

@danzel
Copy link
Member Author

danzel commented Aug 1, 2012

I've reopened the bug so lets take the discussion back there.
Seems solved for me though.

@mourner
Copy link
Member

mourner commented Aug 1, 2012

Could you change the target of the pull to stable branch, so that I could release 0.4.2 stable that works with the clusterer?

@mourner
Copy link
Member

mourner commented Aug 1, 2012

Generally I think that it's better to do bugfixes in the stable branch, so that I could decide whether to merge them into stable or master (depending on how critical a bugfix is).

@danzel
Copy link
Member Author

danzel commented Aug 1, 2012

Shouldn't this go to master then be cherry picked to stable? Happy to change if that's the way you want to do it though

@mourner
Copy link
Member

mourner commented Aug 1, 2012

If I merge this pull into stable, it includes master commits, but I'm not very strong at git — what's an easy way to cherry-pick commits into stable from master after that? Or I'd have to just copy-paste?

mourner added a commit that referenced this pull request Aug 1, 2012
Fix FeatureGroup.removeLayer removing popups
@mourner mourner merged commit f8f04c3 into Leaflet:master Aug 1, 2012
@mourner
Copy link
Member

mourner commented Aug 1, 2012

OK, I read about git cherry-pick command :)

mourner added a commit that referenced this pull request Aug 1, 2012
mourner added a commit that referenced this pull request Aug 1, 2012
@mourner
Copy link
Member

mourner commented Aug 1, 2012

Released Leaflet 0.4.2 with two bugfixes included, you can now put "Requirements: Leaflet 0.4.2" into your readme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants