null check setting of document.onselectstart #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, thank you for using tabs in your source files. most JS is this crappy 2 space formatting that drives me nuts. |
mourner
added a commit
that referenced
this pull request
Aug 10, 2012
null check setting of document.onselectstart
|
Thanks! |
|
I hate the 2-space thing too :) |
|
@mourner would you mind doing a 0.4.5 release with this in it? |
|
Nope, not yet, need to fix some things in the master and then release all the new changes/bugfixes. |
|
Ok, I guess I'll just put up with the automated emails I get every time someone with IE8 hits my site. =) |
|
It would be easier to just put a custom build with this fix on your site :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #892