Add tileBounds option to limit tile loading to a given region #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -325,6 +326,19 @@ L.TileLayer = L.Class.extend({ | |||
| } | |||
| } | |||
|
|
|||
| if(this.options.tileBounds) { | |||
There was a problem hiding this comment.
- Add space after each
if - I think it would make more sense to call it just
bounds.
|
Renamed the option and I ran jake this time to make sure there are no errors. |
| @@ -42,6 +43,10 @@ L.TileLayer = L.Class.extend({ | |||
| this.options.maxZoom--; | |||
| } | |||
|
|
|||
| if (options.bounds) { | |||
| options.bounds = L.LatLngBounds(options.bounds); | |||
There was a problem hiding this comment.
You should change this to L.latLngBounds (the one you used is a constructor, not a factory method).
|
Thank you adimitrov, this works great for me, +1 for adding this to the master branch. |
jfirebaugh
added a commit
to mapbox/mapbox.js
that referenced
this pull request
Feb 22, 2013
Depends on Leaflet/Leaflet#991.
|
👍 Only refinement I can see is indentation - |
mourner
added a commit
that referenced
this pull request
Feb 25, 2013
Add tileBounds option to limit tile loading to a given region
|
Thanks everyone, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone needs to add a tile overlay that is limited to a given region (ex. city) we need a way to limit the tile requests to this region.