Skip to content

test for 'test select multiple options' in browser.navigation.js fails #39

Closed
bantic opened this Issue Jun 27, 2011 · 3 comments

3 participants

@bantic
bantic commented Jun 27, 2011

I get the following stacktrace. Only one forum digest option comes back as selected, when it should be both. This happens when I run make test on a newly-checked-out clone of the repo.

This is the test that is failing: https://github.com/LearnBoost/tobi/blob/master/test/browser.navigation.test.js#L700

   uncaught: AssertionError: expected { user: 
   { name: '',
     subscribe: 'yes',
     forum_digest: 'weekly',
     signature: '' } } to equal { user: 
   { name: '',
     signature: '',
     subscribe: 'yes',
     forum_digest: [ 'daily', 'weekly' ] } }
    at Object.eql (/Users/bantic/tobi/node_modules/should/lib/should.js:291:10)
    at /Users/bantic/tobi/test/browser.navigation.test.js:720:30
    at IncomingMessage.<anonymous> (/Users/bantic/tobi/lib/browser.js:201:24)
    at IncomingMessage.emit (events.js:81:20)
    at HTTPParser.onMessageComplete (http.js:133:23)
    at Client.onData [as ondata] (http.js:1484:27)
    at Client._onReadable (net.js:683:27)
    at IOWatcher.onReadable [as callback] (net.js:177:10)


   uncaught: Error: 'test select multiple options' timed out
    at Object._onTimeout (/Users/bantic/tobi/node_modules/expresso/bin/expresso:835:43)
    at Timer.callback (timers.js:83:39)
@tj
LearnBoost member
tj commented Jun 28, 2011

weird i get that now too, something must have changed

@mhemesath

This should be resolved now, can we close this?

@bantic
bantic commented Jun 30, 2011

Yeah...they pass for me now, too. Thanks.

@bantic bantic closed this Jun 30, 2011
@rgaidot rgaidot pushed a commit that referenced this issue Nov 17, 2013
@mhemesath mhemesath Fix for issue: #39. From what I can see, given the markup, the failur…
…e is what is supposed to happen. Multiple options can't be selected on a select box unless it is given the multiple attribute.


This test should never have passed, unless something in JSDOM changed to only allow multiple selection if the "multiple" attribute is present?
32d5916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.