Skip to content

External site redirecting back to app creates new browser instance #72

Open
wants to merge 2 commits into from

1 participant

@smacintyre

Example use case:

Testing facebook authentication for web sites:

  • browser requests '/auth/facebook' which redirects to app authentication flow
  • browser logs into facebook and is redirected back to application

Current behaviour:

  • Because the host name doesn't match 'undefined' a new browser is created; the cookies are not transferred, session information is lost.

Expected behaviour:

  • Reuse the same browser object used for the initial request to the app. I.e., 'undefined'

Notes:

  • If you are passing an app to Browser, then the host argument is ignored. Attempted to set self.host for this purpose but it caused all sorts of woes.
  • Added new option externalHost for the hostname of the 'undefined' browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.