Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds test for digest, some of phases, and cos #367

Closed
wants to merge 1 commit into from

Conversation

aaronev
Copy link
Contributor

@aaronev aaronev commented Oct 3, 2017

Copy link
Contributor

@jaredatron jaredatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase this off of master and use the new tools. see web-server/index.test.js as an example. please refactor and resubmit

"compression": "^1.7.0",
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops you accidentally checked in a merge conflict. Please remove these bad lines, rebase this branch, do a clean npm install and make sure to checkin changes to the package-lock.json

@@ -19,7 +19,8 @@ module.exports = app => {
request.user = {
id: 'this is a fake user!!',
handle: 'Fake News',
roles: ['learner'],
isAdmin: true,
roles: ['learner', 'admin'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we make this fake learner an admin only in special cases

@jaredatron jaredatron closed this Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants