fix: Reduces database queries by avoiding queries with empty ins. (#511)

Author: ryasmi

src/apps/statements/repo/modelsRepo/getStatementsByIds/memory.ts

@@ -5,6 +5,9 @@ import Signature from './Signature';
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, ids }) => {
+    if (ids.length === 0) {
+      return [];
+    }
     const filteredModels = config.state.statements.filter((model) => {
       return (
         includes(ids, model.statement.id) &&

src/apps/statements/repo/modelsRepo/getStatementsByIds/mongo.ts

@@ -11,6 +11,9 @@ interface Result {
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, ids }) => {
+    if (ids.length === 0) {
+      return [];
+    }
     const collection = (await config.db()).collection(STATEMENTS_COLLECTION_NAME);
 
     const query = {

src/apps/statements/repo/modelsRepo/getUpRefsByIds/memory.ts

@@ -16,6 +16,9 @@ const getTargetId = (model: StoredStatementModel) => {
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, targetIds }) => {
+    if (targetIds.length === 0) {
+      return [];
+    }
     const filteredModels = config.state.statements.filter((model) => {
       return (
         model.statement.object.objectType === 'StatementRef' &&

src/apps/statements/repo/modelsRepo/getUpRefsByIds/mongo.ts

@@ -14,6 +14,9 @@ interface Result {
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, targetIds }) => {
+    if (targetIds.length === 0) {
+      return [];
+    }
     const collection = (await config.db()).collection(STATEMENTS_COLLECTION_NAME);
 
     const query = {

src/apps/statements/repo/modelsRepo/getVoidersByIds/memory.ts

@@ -7,6 +7,10 @@ import Signature from './Signature';
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, ids }) => {
+    // istanbul ignore next - this is checked higher in the code.
+    if (ids.length === 0) {
+      return [];
+    }
     const query = (statement: Statement) => {
       return (
         statement.verb.id === voidVerbId &&

src/apps/statements/repo/modelsRepo/getVoidersByIds/mongo.ts

@@ -7,6 +7,10 @@ interface Result { readonly statement: { readonly id: string }; }
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, ids }) => {
+    // istanbul ignore next - this is checked higher in the code.
+    if (ids.length === 0) {
+      return [];
+    }
     const query = {
       'statement.id': { $in: ids },
       ...voidQuery,

src/apps/statements/repo/modelsRepo/getVoidersByObjectIds/memory.ts

@@ -8,6 +8,9 @@ import Signature from './Signature';
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, ids }) => {
+    if (ids.length === 0) {
+      return [];
+    }
     const query = (statement: Statement) => {
       return (
         statement.verb.id === voidVerbId &&

src/apps/statements/repo/modelsRepo/getVoidersByObjectIds/mongo.ts

@@ -7,6 +7,9 @@ interface Result { readonly statement: { readonly object: { readonly id: string
 
 export default (config: FacadeConfig): Signature => {
   return async ({ client, ids }) => {
+    if (ids.length === 0) {
+      return [];
+    }
     const query = {
       'statement.object.id': { $in: ids },
       ...voidQuery,

src/apps/statements/tests/store.test.ts

@@ -30,6 +30,14 @@ describe('get statement', () => {
     assertNoStatements(actualStatements as Statement[]);
   });
 
+  it('should ensure that we do not make unnecessary database queries for refs', async () => {
+    await storeStatements([{
+      actor: { mbox: 'mailto:test@example.org' },
+      verb: { id: 'https://example.org/verb' },
+      object: { id: 'https://example.org/activity' },
+    }]);
+  });
+
   it('should throw an error when the store does not match', async () => {
     const unknownClient = createClientModel({
       lrs_id: '5988ff000000000000000001',