[FEATURE] Add telemetry CAT-66 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norvin-yecla-lrn
force-pushed
the
CAT-66/feature/add-telemetry
branch
from
2564a64 to
e1899fe
Compare
| /// <returns>The version number</returns> | ||
| public string getSdkVersion() | ||
| { | ||
| return GetType().Assembly.GetName().Version.ToString(); |
Contributor
Author
There was a problem hiding this comment.
This will return a string with four sections separated by periods. i.e. 0.0.8.0
norvin-yecla-lrn
force-pushed
the
CAT-66/feature/add-telemetry
branch
from
b117dc2 to
9855d6c
Compare
norvin-yecla-lrn
force-pushed
the
CAT-66/feature/add-telemetry
branch
from
9855d6c to
a7b1e35
Compare
| /// </summary> | ||
| /// <returns>A signature hash for the request authentication</returns> | ||
| private string generateSignature() | ||
| public string generateSignature() |
Contributor
Author
There was a problem hiding this comment.
Turned to public so we can use it in the tests. In Java SDK this is also a public method.
Contributor
rhiannon-eldridge-lrn
left a comment
rhiannon-eldridge-lrn
left a comment
There was a problem hiding this comment.
Just needs some minor changes to be consistent with the existing code, otherwise looks great to me.
gonzalozawa
reviewed
Aug 6, 2019
flakeparadigm
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds telemetry to all requests made using the ASP.NET SDK.
We tried to follow how it works in the PHP SDK (relevant function here: https://github.com/Learnosity/learnosity-sdk-php/blob/master/src/LearnositySdk/Request/Init.php#L174)