Implement SPAKE2 (for I1024) #3

jml · 2017-05-19T08:03:38Z

A "working" implementation of SPAKE2 with the I1024 group.

Rejiggers documentation quite a lot
Defines new Group typeclass and implements it for the IntegerGroup that's in the Python implementation
Implements all of the protocol stuff that sits on top of the mathematics
Adds an entrypoint for testing interoperability

This is ready to merge, IMO.

Future work:

Ed25519 implementation
Move things from the interop entrypoint either into the library or into documentation
Expand the module documentation
Maybe hard-code some of the interoperability lessons as tests. Not sure how to do this.
Make the Haddock for the main Crypto.Spake2 module more accessible

Much input derived from a PR to implement this for Javascript: bitwiseshiftleft/sjcl#273

Includes full-ish `createSessionKey` implementation

Also implement our own Group, but it's a really crappy one that must not be used for cryptography.

Doesn't pass, but at least doesn't crash due to `notImplemented`

I1024 only one provided so far Update interop to use i1024 group A better test of interoperability. Still fails.

Gives us more control for doing experiments.

- capital "M" etc. for seed - correct HKDF information (remove a space) - do modulo arithmetic correctly to get byte size - hash session key elements as byte digests, not as hex digests Unrelated - export `elementSizeBytes` (for testing) - derive Eq, Show for group (for testing) - refactor arbitraryElement (for easier comparison with Python)

A lot has been learned, so a lot of the documentation can be summarised. This isn't as good as it could be, but hopefully more will follow.

jml · 2017-05-28T14:45:40Z

I'm going to merge this now.

I'd still really like feedback, especially on:

correct use of mathematical terminology
how understandable the code is
whether the docs are useful

And, for @exarkun in particular, I'd be happy to answer any questions about Haskell things that are strange or unfamiliar.

jml force-pushed the even-more-learning branch 4 times, most recently May 22, 2017

jml added 14 commits May 19, 2017

Lots of documentation for the protocol

b7f85a8

Much input derived from a PR to implement this for Javascript: bitwiseshiftleft/sjcl#273

Initial sketch of SPAKE2 protocol

5cabb28

Includes full-ish `createSessionKey` implementation

Interoperability harness

45938a2

Start gluing protocol to math

767f2c9

Hook up most of protocol and define Group typeclass

f3d0039

Also implement our own Group, but it's a really crappy one that must not be used for cryptography.

Construct protocol in interop test

80b9c7c

Full interop testing

b3a9fc1

Doesn't pass, but at least doesn't crash due to `notImplemented`

Implement passwordToScalar

908441f

Implement arbitraryElement

cb096db

Update current status

d6df17f

Move expandData to util module

88a1018

IntegerGroup implementation

c4cd83f

I1024 only one provided so far Update interop to use i1024 group A better test of interoperability. Still fails.

Factor out number serialization

9a2bc05

Gives us more control for doing experiments.

jml force-pushed the even-more-learning branch to 72f37ee May 25, 2017

Re-organize documentation

1dabc99

A lot has been learned, so a lot of the documentation can be summarised. This isn't as good as it could be, but hopefully more will follow.

jml changed the title ~~[WIP] Even more learning~~ Implement SPAKE2 (for I1024) May 25, 2017

jml requested a review from exarkun May 25, 2017

jml added 3 commits May 25, 2017

Split Group typeclass to separate module

c258c6b

Move group implementations to own module

4a7c990

Haddock improvements

f87f52d

jml mentioned this pull request May 26, 2017

Ed25519 implementation #4

Merged

jml merged commit dced3d6 into master May 28, 2017

jml deleted the even-more-learning branch May 28, 2017

LeastAuthority / haskell-spake2

Implement SPAKE2 (for I1024) #3

Implement SPAKE2 (for I1024) #3

jml commented May 19, 2017 •

edited

jml commented May 28, 2017

LeastAuthority / haskell-spake2

Implement SPAKE2 (for I1024) #3

Implement SPAKE2 (for I1024) #3

Conversation

jml commented May 19, 2017 • edited

jml commented May 28, 2017

jml commented May 19, 2017 •

edited