[DO NOT MERGE] Some attempts at 17.5 fixes. #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exarkun
reviewed
Jun 5, 2017
| nameResolver = _FakeResolver() | ||
|
|
||
| MemoryReactor = _ResolvingMemoryReactor | ||
| expectedTCPConnectResult = '1.2.3.4' |
There was a problem hiding this comment.
Oughtn't this clearly be part of the public testing interface published by Twisted itself?
This was referenced Aug 31, 2017
Closed
|
Thanks. Superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@exarkun
This contains fixes for most of the issues present in 17.1 and 17.5, although I've only tested on 17.5. This code is in no way ready for landing, but it does identify the issues so that you may tackle them in a cleaner way :)
The largest change is that connectSSL isn't used by Agent anymore, it's a regular TCP connection with a wrapped protocol. This causes the failure I haven't fixed in
test_https_bearer_token_authorization, and would need a special 17.1+ codepath to verify that it's doing the right thing.Feel free to use the code, even though it's not up to spec :)