Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd manageBuyOffer support (help needed) #6
Conversation
MisterTicot
changed the title
(Thanks @lenondupe)
This comment has been minimized.
This comment has been minimized.
|
It's now working fine thanks to @lenondupe. It's still missing a test though. Is the test format the tx XDR converted to hex? |
This comment has been minimized.
This comment has been minimized.
|
Anybody here??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MisterTicot commentedOct 24, 2019
This is an attempt to add support for manageBuyOffer.
However, it stalls on "Confirm Transaction".
I've tested the new display logic for manageSellOffer. I've also tested the display logic for manageBuyOffer by setting
manageOffer.buyto true in manageSellOffer parser. Both works.I've read the changes for
stellar_parser.c&stellar_types.hseveral time but all seems right.My conclusion is that something else have to be changed in order to add a new operation, but I don't find it. At that point I think I need help.
My conclusion is that I forgot something