Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manageBuyOffer support (help needed) #6

Open
wants to merge 2 commits into
base: master
from

Conversation

@MisterTicot
Copy link

MisterTicot commented Oct 24, 2019

This is an attempt to add support for manageBuyOffer.

However, it stalls on "Confirm Transaction".

I've tested the new display logic for manageSellOffer. I've also tested the display logic for manageBuyOffer by setting manageOffer.buy to true in manageSellOffer parser. Both works.

I've read the changes for stellar_parser.c & stellar_types.h several time but all seems right.

My conclusion is that something else have to be changed in order to add a new operation, but I don't find it. At that point I think I need help.

My conclusion is that I forgot something

@MisterTicot MisterTicot changed the title Add manageBuyOffer support (need help) Add manageBuyOffer support (help needed) Oct 24, 2019
(Thanks @lenondupe)
@MisterTicot

This comment has been minimized.

Copy link
Author

MisterTicot commented Oct 24, 2019

It's now working fine thanks to @lenondupe.

It's still missing a test though. Is the test format the tx XDR converted to hex?

@MisterTicot

This comment has been minimized.

Copy link
Author

MisterTicot commented Nov 1, 2019

Anybody here???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.