Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite socket logic to fix race condition in transport #477

merged 3 commits into from Jan 31, 2020


Copy link

gre commented Jan 29, 2020

  • rewrite the socket logic in order to make it work with upcoming script runner as well as the previous one
  • add command appsInstallAll
  • make appsUpdateTestAll to do a listApps after EACH install. It reveals the bug in current script runner and assess it's in fact fixed in the upcoming. We do that to also verify that the hash of install app matches the hash of the api (and we spot and reported problems on Nano X)
  • Introduce a way to mock the socket that is enabled in MOCK=1 mode (will be eventually used for UI test purpose)
  • the socket.js logic have the mecanism to detect the "allow manager" built in into it which allowed to simplify some code
  • the logs observable exported from api/socket has been dropped because we are just using the @ledgerhq/logs like other parts
  • the progress event out of the apps logic is throttle by 100ms

This will require heavy testing and we'll do it in context of "lldv2" and "llm", i'll release a .alpha for this purpose

@gre gre force-pushed the socket-rework branch from b04fed2 to c04eff3 Jan 29, 2020
@gre gre force-pushed the socket-rework branch from c04eff3 to ba3c4c8 Jan 29, 2020

This comment has been minimized.

Copy link

meriadec commented Jan 29, 2020


gre added 2 commits Jan 29, 2020
@gre gre merged commit 327f388 into master Jan 31, 2020
2 checks passed
2 checks passed
deploy/netlify Deploy preview ready!
@gre gre deleted the socket-rework branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.