Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LL-2015 Change error for not enough spendable balance #559

Merged
merged 1 commit into from Mar 12, 2020

Conversation

@juan-cortes
Copy link
Collaborator

juan-cortes commented Mar 10, 2020

Due to the change in wording required by @dasilvarosa to solve LL-2015 we need to change the way we call the error to provide the dynamic parts (currency name and amount). Once this is merged we can bump live-common on desktop and mobile to benefit from this.

Currently waiting for confirmation on whether we want the unit to be included or not in the wording.
image

cc @dasilvarosa

@now

This comment has been minimized.

Copy link

now bot commented Mar 10, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/ledgerhq/ledger-live-common/6rtwx610y
Preview: https://ledger-live-common-git-fork-juan-cortes-ll-2015.ledgerhq.now.sh

@juan-cortes juan-cortes requested a review from gre Mar 10, 2020
@juan-cortes juan-cortes force-pushed the juan-cortes:LL-2015 branch from 064131b to 62f254e Mar 10, 2020
@gre
gre approved these changes Mar 11, 2020
@juan-cortes juan-cortes force-pushed the juan-cortes:LL-2015 branch from 1dccd18 to c12f525 Mar 12, 2020
@gre gre merged commit 344db7b into LedgerHQ:master Mar 12, 2020
6 checks passed
6 checks passed
jest (macos-latest)
Details
jest (windows-latest)
Details
jest (ubuntu-latest)
Details
cli (macos-latest)
Details
cli (ubuntu-latest)
Details
now Deployment has completed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.