Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining known issues with ERC20 implementation #2172

Open
gre opened this issue Jul 9, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@gre
Copy link
Member

commented Jul 9, 2019

Below are listed known issues with ERC20 experimental implementation in Ledger Live 1.11.0 that should be fixed soon. checked items are only fixed in our develop branch, not yet in 1.11.0.

  • some ERC20 tokens show a wrong balance. for instance instead of seeing 10000 you see 0.0000000000121 (scientific notation issue in current backend)
  • Ledger Live Mobile app does not yet support ERC20.
  • some token might be missing. Please contact us if you see important ones missing (we do not yet have a way to see the actual list)
  • UX: No current way to see the tokens supported / select a token to receive.
  • UX: as accounts need to be "updated" (aka re-added) to benefit the update, we are going to make a dedicated flow to have a better UX.

@gre gre referenced this issue Jul 9, 2019

Merged

Prepare 1.11.0 #2164

@01BTC10

This comment has been minimized.

Copy link

commented Jul 11, 2019

I tested ledger-live-desktop-1.11.0-linux-x86_64.AppImage and can confirm that I now see my chainlink tokens but the balance is wrong. However, last operations history show correct amount and price. Tokens are also missing from the asset distribution.

@gre

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@01BTC10 thanks for feedback.

Tokens are also missing from the asset distribution.

can you explain more? this is what supposed to happen:

Capture d’écran 2019-07-11 à 10 07 31

@01BTC10

This comment has been minimized.

Copy link

commented Jul 11, 2019

@01BTC10 thanks for feedback.

Tokens are also missing from the asset distribution.

can you explain more? this is what supposed to happen:

Capture d’écran 2019-07-11 à 10 07 31

Sorry I see it now. I probably missed it because the balance is wrong and below 0.

@brent-riva

This comment has been minimized.

Copy link

commented Jul 14, 2019

@gre any chance we could get an updated build of the pre-release with the latest bug fixes? I.e. 1.11.1

Specifically regarding: #2176, #2181, and #2173

@gre gre pinned this issue Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.