New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new derivations & isIterable system #1599

Merged
merged 3 commits into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@gre
Member

gre commented Oct 25, 2018

integrate latest live-common with new derivations on ETH.

Type

polish

Context

LedgerHQ/ledger-live-common#88

Parts of the app affected / Test plan

test plan: on https://ledger-live-tools.netlify.com/ make sure you see the live-common version under in a footer (otherwise use https://5bd1c82ce39e7c3655d8bb4c--ledger-live-tools.netlify.com/ ) and go to derivations to see the new address. send a minimal amount in new eth address to check that addresses are correctly discovered. make sure there is no discovery regression on the other paths.

@gre gre added HODL and removed HODL labels Oct 25, 2018

@meriadec

This comment has been minimized.

Member

meriadec commented Oct 29, 2018

looks like a simple deps conflict

@Arnaud97234

This comment has been minimized.

Contributor

Arnaud97234 commented Nov 8, 2018

Test with path 44'/60'/14'/5'/16 and 44'/60'/0'/0' for ETH and 44'/144'/0'/0' for XRP.
New addresses are discovered during scan and accounts are added properly in Ledger Live.

Didn't test for XRP path 44'/144'/14'/5'/16 because I don't want to block an other 20 XRP.

@gre gre force-pushed the gre:new-derivations branch from 07b2109 to 384d032 Nov 9, 2018

@gre gre merged commit 240dfab into LedgerHQ:develop Nov 9, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment