New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sqlite gaps while scanning accounts #1609

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@meriadec
Member

meriadec commented Oct 28, 2018

LL-329

TL;DR, the PR should only be merged once this line is updated with ORDER BY idx in lib-ledger-core, to fix the getNextAccountCreationInfo (actually it returns always index 0 when there is gaps in created accounts).

to reproduce the problem:

  • open LL with empty user data
  • scan currency with (at least) 3 accounts
  • import the 3nd one
  • clear cache
  • scan again
  • error is throw (account 0 does not exists)

to test the resolution

  • switch to this branch
  • do same thing and
  • realize it doesnt throw
  • shutdown your computer
@meriadec

This comment has been minimized.

Member

meriadec commented Oct 30, 2018

@KhalilBellakrid can you give an ETA on when you will be able to publish a new libcore version including the patch?

@meriadec meriadec removed the HODL label Nov 5, 2018

@Arnaud97234

This comment has been minimized.

Contributor

Arnaud97234 commented Nov 6, 2018

Test with bitcoin and zcash accounts. It works properly.

@gre gre merged commit 64edc81 into LedgerHQ:develop Nov 6, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@meriadec meriadec deleted the meriadec:fix-LL-329 branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment