Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LL-1028 Added generic error for zero fees on bitcoinkind currencies #1812

Merged
merged 2 commits into from Feb 14, 2019

Conversation

Projects
None yet
4 participants
@juan-cortes
Copy link
Collaborator

juan-cortes commented Feb 14, 2019

image

This error should eventually be moved to @ledgerhq/errors

@juan-cortes juan-cortes requested review from gre and Arnaud97234 Feb 14, 2019

@juan-cortes juan-cortes changed the title Added generic error for zero fees on bitcoinkind currencies LL-1028 Added generic error for zero fees on bitcoinkind currencies Feb 14, 2019

Show resolved Hide resolved src/components/FeesField/BitcoinKind.js Outdated
@juan-cortes

This comment has been minimized.

Copy link
Collaborator Author

juan-cortes commented Feb 14, 2019

Moved the error to @ledgerhq/errors @gre

@gre

gre approved these changes Feb 14, 2019

@gre gre merged commit c4d8811 into LedgerHQ:develop Feb 14, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@gre gre referenced this pull request Feb 26, 2019

Merged

Preparing 1.5.0 #1829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.