Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding LL with a new Nano X #1815

Merged
merged 6 commits into from Feb 19, 2019

Conversation

Projects
None yet
4 participants
@valpinkman
Copy link
Collaborator

valpinkman commented Feb 19, 2019

Add steps to set up a brand new Ledger Nano X from onboarding

Type

Feature

Context

LL-635 LL-636 LL-637

Parts of the app affected / Test plan

Onobarding

init
init selected
write pin
restore

valpinkman added some commits Feb 19, 2019

@valpinkman valpinkman force-pushed the valpinkman:feat/onboarding-init-nanox branch from 0143856 to 0d5c6cf Feb 19, 2019

@gre
Copy link
Member

gre left a comment

see comments. some part that confused me about the semantic of deviceType and the need for the 2 helpers/devices functions

Show resolved Hide resolved src/components/Onboarding/index.js Outdated
Show resolved Hide resolved src/helpers/devices.js Outdated
Show resolved Hide resolved src/helpers/devices.js Outdated
Show resolved Hide resolved src/reducers/onboarding.js Outdated
Show resolved Hide resolved src/components/Onboarding/steps/SelectPIN/index.js Outdated
Show resolved Hide resolved src/components/Onboarding/steps/SelectPIN/index.js Outdated

@valpinkman valpinkman force-pushed the valpinkman:feat/onboarding-init-nanox branch from 97c6cef to 4c55166 Feb 19, 2019

@valpinkman valpinkman requested review from gre , Arnaud97234 and MortalKastor Feb 19, 2019

@valpinkman valpinkman removed request for gre , Arnaud97234 and MortalKastor Feb 19, 2019

@valpinkman valpinkman added HODL and removed HODL labels Feb 19, 2019

@Arnaud97234
Copy link
Contributor

Arnaud97234 left a comment

Bug found
During Onboarding -> Security Checklist. If user answer "No" to "Did you choose your PIN code by yourself?" or "Did you save your recovery phrase by yourself?" he is redirected to an error screen. The device picture on the screen is the one corresponding to the Blue.

How to reproduce

  • Start onboarding
  • Select "Use an initialized device" then select "NanoX" -> Click "Continue"
  • Answer "No" for "Did you choose your PIN code by yourself?"

screenshot 2019-02-19 at 17 09 09

@gre

This comment has been minimized.

Copy link
Member

gre commented Feb 19, 2019

this is the NanoXX :trollface:

@valpinkman

This comment has been minimized.

Copy link
Collaborator Author

valpinkman commented Feb 19, 2019

@Arnaud97234 waiting for some new illustrations

@valpinkman

This comment has been minimized.

Copy link
Collaborator Author

valpinkman commented Feb 19, 2019

this is the NanoXX :trollface:

Nano X+

@valpinkman valpinkman requested review from Arnaud97234 and removed request for MortalKastor Feb 19, 2019

@gre

gre approved these changes Feb 19, 2019

@gre gre merged commit 5ea1adc into LedgerHQ:develop Feb 19, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@valpinkman valpinkman deleted the valpinkman:feat/onboarding-init-nanox branch Feb 20, 2019

@gre gre referenced this pull request Feb 26, 2019

Merged

Preparing 1.5.0 #1829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.