Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate transaction with Nano X #1820

Merged
merged 3 commits into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@valpinkman
Copy link
Collaborator

valpinkman commented Feb 21, 2019

Type

feat

Context

LL-638

@valpinkman valpinkman changed the base branch from master to develop Feb 21, 2019

@valpinkman valpinkman force-pushed the valpinkman:feat/nanox-validate-transaction branch from 5543604 to 0c171de Feb 21, 2019

@Arnaud97234
Copy link
Contributor

Arnaud97234 left a comment

OK for operation validation using NanoX.

It miss the screen update for Recipient address verification (Receive flow) :
https://app.zeplin.io/project/5a672fa9c1729867100289cd/screen/5c61880fc6fba37e32300f8c

@valpinkman valpinkman requested a review from Arnaud97234 Feb 22, 2019

@gre

gre approved these changes Feb 22, 2019

@valpinkman valpinkman merged commit 9448ac4 into LedgerHQ:develop Feb 22, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@gre gre referenced this pull request Feb 26, 2019

Merged

Preparing 1.5.0 #1829

@valpinkman valpinkman deleted the valpinkman:feat/nanox-validate-transaction branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.