Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Set nLockTime for Komodo transactions #1825
This PR sets nLockTime to a value slightly in the past for Komodo transactions to enable reward claiming on UTXOs created by Ledger Live.
I'm aware you don't want to support the actual claim functionality inside Ledger Live, that's why we built our Ledger reward claiming app as an external web app (https://github.com/atomiclabs/ledger-kmd-reward-claim). However, the only requirement for a UTXO to be able to claim interest is that it has nLockTime set.
All Komodo wallets set nLockTime to a value slightly in the past for this reason. (It's actually a good idea to always set nLockTime for other reasons too https://bitcoin.stackexchange.com/a/48385/90269). But due to the fact that Ledger Live doesn't set nLockTime, as soon as the users spends a UTXO via Ledger Live, they can't earn any rewards on their change UTXO.
Parts of the app affected / Test plan
Only Komodo transactions are affected. Currently, Komodo transactions don't have nLockTime set. If you test this PR and make a Komodo transaction, you'll see nLockTime is now set to a value slightly in the past (
It wouldn't be a bad idea to do this for all currencies, not just Komodo (https://bitcoin.stackexchange.com/a/48385/90269). But I've limited it to just Komodo for this PR to avoid making any decisions for you.