Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Native Segwit support #2026

Merged
merged 1 commit into from May 29, 2019

Conversation

@gre
Copy link
Member

commented May 27, 2019

馃嵕Native Segwit (bech32)

Capture d鈥檈虂cran 2019-05-27 a虁 11 46 19

Shipping it as an experimental feature for now

Capture d鈥檈虂cran 2019-05-27 a虁 17 53 44

Type

feature

Context

Fixes #1842 Fixes #1051

Parts of the app affected / Test plan

  • not enabling Native Segwit must not show you native segwit accounts in scan accounts
  • enabling Native Segwit will allow to scan Native Segwit accounts, if there are some. In 84'/0'/x' path. the new accounts that can be created are both on Segwit and Native Segwit because there is a usecase for both (some exchanges don't support sending to native segwit).
  • disabling Native Segwit after importing some native segwit accounts should be allowed and does not break them
  • Synchronisation works fine.
  • Receive flow works fine.
  • Send flow works fine. Can send from native segwit to legacy. Can send from native segwit to segwit. Reverse to be tested as well.
@gre gre referenced this pull request May 27, 2019
@Arnaud97234
Copy link
Contributor

left a comment

Bug found

When sending funds to a Native segwit account, outputs are missing (portfolio -> Last operations AND operation details) for the send operation (OK for receive transaction).
Ok when sending from native segwit to Segwit / Legacy.

Screenshot 2019-05-27 at 19 06 14
Screenshot 2019-05-27 at 19 07 52

How to reproduce

  • Go to Accounts -> Select a BTC account
  • Send funds to native segwit account
  • Verify transaction in portfolio / Verify transaction in operation details.

@Arnaud97234 Arnaud97234 requested review from Arnaud97234 and removed request for Arnaud97234 May 27, 2019

@gre

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

Noticed the same glitch @Arnaud97234 , probably a bug in libcore, I'll report back .

@KhalilBellakrid

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

@gre @Arnaud97234 I tried with some infos that Ga毛tan gave me and I don't reproduce, @Arnaud97234 could you please provide your xpub (testnet) ?

@gre

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

it seems to be a temporary glitch after doing a tx @KhalilBellakrid

@gre gre merged commit b3ba150 into LedgerHQ:develop May 29, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@KhalilBellakrid

This comment has been minimized.

Copy link
Collaborator

commented May 29, 2019

I adapted the optimistic update to native Segwit transactions: LedgerHQ/lib-ledger-core#229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.