fix(hooks): keep .maigo/ out of host repo via git exclude#2
Merged
Conversation
repo_detect's SessionStart hook now ensures .maigo/ is git-ignored on every session. maigo writes plan.md, review-rubric.md, pr-comments.md and retry logs into .maigo/ at the repo root, but nothing made git ignore them, so they leaked as untracked files (and could be committed) in any consumer repo whose tracked .gitignore lacks the entry — e.g. apache/airflow. The rule is appended to the repo's info/exclude (resolved via `git rev-parse --git-path`, so it works from a linked worktree) rather than the tracked .gitignore, which the host repo owns and must not be mutated. Idempotent and fail-open: skips when already ignored (global excludesfile, tracked .gitignore, or a prior run) or when cwd is not a git repo. Docs corrected: the README previously claimed ".gitignore 已加入 .maigo/", which no code ever did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repo_detect's SessionStart hook now ensures .maigo/ is git-ignored on every session. maigo writes plan.md, review-rubric.md, pr-comments.md and retry logs into .maigo/ at the repo root, but nothing made git ignore them, so they leaked as untracked files (and could be committed) in any consumer repo whose tracked .gitignore lacks the entry — e.g. apache/airflow.
The rule is appended to the repo's info/exclude (resolved via
git rev-parse --git-path, so it works from a linked worktree) rather than the tracked .gitignore, which the host repo owns and must not be mutated. Idempotent and fail-open: skips when already ignored (global excludesfile, tracked .gitignore, or a prior run) or when cwd is not a git repo.Docs corrected: the README previously claimed ".gitignore 已加入 .maigo/", which no code ever did.