New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depend on small extracted subset of numpy #62

Open
rrva opened this Issue Oct 16, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@rrva

rrva commented Oct 16, 2015

The dependency on numpy is unfortunate since it takes quite some time to compile numpy (can be mitigated by whl files) but still..

Proposing to extract the actual needs from numpy into a separate lib and to make both numpy and javabridge depend on that.

@rrva

This comment has been minimized.

rrva commented Oct 16, 2015

Or, if extracting what is needed from numpy is not feasible, consider duplicating that code inside javabridge (if it reduces install time for javabridge)

@LeeKamentsky

This comment has been minimized.

Owner

LeeKamentsky commented Oct 27, 2015

I think that the best we could do would be to make numpy an optional dependency. Numpy lets us efficiently process large arrays of numeric data from Java (which just happens to be the use case for which it was designed), so one approach would be to have methods for populating or reading arrays using Python primitives (bool, int and float) and a second set that used numpy, conditionally included if numpy was available.

An alternative would be to drop support for array interoperability if numpy isn't available.

We use the numpy array type - it would be difficult to extract or patch around only that functionality from numpy.

Not work I can justify doing myself, but would consider a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment