New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implementation of deprecated PGP "quick check" #31

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@sarneaud

sarneaud commented Sep 11, 2016

PGP's block cipher mode makes the first two bytes of the second block a duplicate of two bytes from the IV. This redundancy was included in PGP as a quick way to check the right decryption key is being used, but was later discovered to not be cryptographically secure -- in some cases it can be exploited to partially decrypt messages (https://eprint.iacr.org/2005/033). Modern, secure implementations don't use the check, so the two bytes are only there for backwards compatibility.

The OpenPGP standard now includes encryption with cryptographic hashes for integrity protection.

@Legrandin

This comment has been minimized.

Show comment
Hide comment
@Legrandin

Legrandin Oct 19, 2016

Owner

Thanks. Merged as f80debf.

Owner

Legrandin commented Oct 19, 2016

Thanks. Merged as f80debf.

@Legrandin Legrandin closed this Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment