Add feature to embed pictrs in lemmy binary (fixes #2627) #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
embed-pictrs
branch
from
907b73c
to
a7f07e2
Compare
Nutomic
commented
Dec 26, 2022
Nutomic
force-pushed
the
embed-pictrs
branch
from
05ec968
to
ec703f2
Compare
dessalines
approved these changes
Dec 29, 2022
|
make sure you test this with whatever containers you build. pict-rs isn't just a rust library, it shells out to ffmpeg, imagemagick, and exiftool, so those need to be installed and available in your path |
|
Yes this will have to be added to documentation. At first I would only use it for native install because it can clearly be simplified this way. |
Nutomic
force-pushed
the
embed-pictrs
branch
3 times, most recently
from
91a3b7c
to
9d15492
Compare
dessalines
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try this, start lemmy with
cargo run --features embed-pictrsand then start lemmy-ui. For now image uploads are failing withthread 'actix-rt|system:0|arbiter:0' panicked at 'No auth header for picture upload', crates/routes/src/images.rs:97:6, but that seems like a problem with lemmy-ui (using latest main branch).