Skip to content

Allow users to delete images they uploaded to via pictshare. #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StaticallyTypedRice opened this issue Feb 4, 2020 · 6 comments
Closed
Labels
extra: good first issue Good for newcomers

Comments

@StaticallyTypedRice
Copy link
Contributor

StaticallyTypedRice commented Feb 4, 2020

So far it appears that the de.lemmy.ml pictshare instance is completely separate from the Lemmy instance. In the future, we really should link the uploaded images to the account, if for nothing else other than allowing the user to manually delete them. This is important for privacy and will help with compliance with the GDPR and CCPA.

@dessalines dessalines added the extra: good first issue Good for newcomers label Feb 5, 2020
@dessalines
Copy link
Member

This is possible using the returned delete code, that the front end could provide in some way. If someone else would like to tackle this go ahead: https://github.com/HaschekSolutions/pictshare/blob/master/rtfm/API.md#example-2

@StaticallyTypedRice
Copy link
Contributor Author

StaticallyTypedRice commented Feb 5, 2020

This is possible using the returned delete code, that the front end could provide in some way. If someone else would like to tackle this go ahead: https://github.com/HaschekSolutions/pictshare/blob/master/rtfm/API.md#example-2

I think the way to go about this would be to store records of image uploads and delete codes in the Lemmy database, and have a panel in the logged in user's page to delete them. When the account is deleted, all uploaded files should also be deleted as the GDPR/CPPA probably requires this since images may very well contain personal information.

It'd also be a good idea to block off pictshare to anyone not logged in to prevent it from being abused by people, for example if they're looking for a free image host, and we don't have any orphaned images.

@Nutomic
Copy link
Member

Nutomic commented Feb 5, 2020

@Charleshthomasiii
Copy link
Contributor

Can the geturl.php call return the delete url for existing pictshare images? Otherwise, I'm not sure how to get the delete url.

@StaticallyTypedRice
Copy link
Contributor Author

StaticallyTypedRice commented Feb 8, 2020

Can the geturl.php call return the delete url for existing pictshare images? Otherwise, I'm not sure how to get the delete url.

I think the delete URL is returned in the HTTP response when the image is first uploaded.

@maltfield
Copy link

See also this ticket to add a section to the Lemmy UI for users to be able to delete individual images without having to delete their account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extra: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants