Setting `community.hidden` should be part of `CommunityVisibility` enum

[Nutomic]

Hiding a community from all feed is also a type of visibility, so it makes sense to merge all of them into the same setting. This will also make it easier to show the setting in the ui, as its just another dropdown option. Have to see how exactly this should federate.

[dessalines]

I think private should probably be separated out instead. Then the enum could be Public, LocalOnly, or Hidden, with private being optional for all those.

[Nutomic]

For UX it makes a lot of sense to have all these as part of the same visibility setting, and its also easier to implement. Otherwise its ambiguous what a private + public, or private + hidden community would mean.

[dessalines]

Private seems to be about approval anyway. It looks like there's already a ApprovalRequired on subscribedtype. Is there any difference between these?

[Nutomic]

ApprovalRequired is the one used by private community.

[dessalines]

IMO that should be moved to its own column then (either private, or approval_required). Because then you can have a Public or LocalOnly community, that requires approval.

[Nutomic]

A public community that requires manual approval to follow? What would be the purpose of that? Anyway it would be a separate new feature.

[dessalines]

Public communities that require approval to join, might be useful to some. Maybe not for visibility alone, but if there were posting/commenting restrictions attached to it also.

Either way to me visibility is a different concept from approval_required. But its ultimately up to you as you're the one adding it.