Hide community v2 #2055

dayinjing · 2022-01-22T22:35:00Z

Wanted a cleaner PR because I messed up prev branch with a rebase.

Fixing problems found with,

#2017

And then #2032

For issue #1980

This PR does the following,

Adds the ability to hide or unhide a community with a new put endpoint example curl usage,

curl -X PUT http://localhost:1236/api/v3/community/hide \   
-H "Content-Type: application/json" \
-d \
'{"community_id":3,"hidden":true,"reason":"controversal","auth":"Foo"}'

Hidden communities do not show up in all, local, or trending unless subscribed
updates mod log to represent that.

~~Still reviewing it so I will ask for a code Review in the chat. Might make some cleanups but ran it through a few simple test cases~~

Ran it over test cases looked over the code, asked some questions below but I think this is mostly ready for review.

migrations/2022-01-04-034553_add_hidden_column/up.sql

crates/db_views_actor/src/community_view.rs

crates/db_views_moderator/src/mod_hide_community_view.rs

dessalines

Sry I'm slow on this, been busy with a few other things.

Just a few changes then I'll do testing.

crates/db_views/src/post_view.rs

crates/db_views_actor/src/community_view.rs

crates/db_views_moderator/src/mod_hide_community_view.rs

migrations/2022-01-04-034553_add_hidden_column/up.sql

…ommunity_view. Dont force non null for reason

dayinjing · 2022-01-29T17:17:31Z

Think I got all these requested changes in the latest commit. I'll look over it later a bit more before I request another review.

crates/db_views/src/post_view.rs

crates/db_views/src/comment_view.rs

crates/db_views/src/post_view.rs

dessalines · 2022-01-31T17:00:40Z

Also lint is failing, run cargo +nightly fmt

dayinjing · 2022-01-31T23:13:56Z

Think I straightened out all those things. Unless something minor was left in a match statement. Went ahead and requested re review. I'll look over it a bit later if no one reviews it tomorrow.

migrations/2022-01-04-034553_add_hidden_column/up.sql

dayinjing · 2022-02-02T16:14:26Z

changed column and tested still working.

dayinjing · 2022-02-09T18:26:32Z

@dessalines Bump

crates/db_schema/src/schema.rs

crates/db_schema/src/source/moderator.rs

dayinjing · 2022-02-14T20:34:40Z

Thanks @dessalines Those are fixed. New checks running

dessalines

Looks good, but I'd like nutomic to do a pass over it as well.

dessalines · 2022-02-14T21:24:54Z

@Nutomic

dessalines · 2022-02-17T20:42:53Z

@Nutomic

Nutomic · 2022-02-17T22:33:27Z

crates/api_crud/src/community/update.rs

+      updated: Some(naive_now()),
+      hidden: Some(data.hidden),
+      ..CommunityForm::default()
+    };


I dont think there is any reason to update icon/banner/nsfw here.

These are mainly my fault, we need to make sure all the nullable fields in every form are Option<Option<..., but that can be a separate PR.

Nutomic · 2022-02-17T22:35:12Z

crates/api_crud/src/community/update.rs

+    let op = UserOperationCrud::EditCommunity;
+    send_community_ws_message(data.community_id, op, websocket_id, None, context).await
+  }
+}


Unrelated to this PR, but later we really need to find a diffent (shorter) way to handle all this. If changing a single field needs so much code, it creates way too much bloat.

We can always create specific helper functions rather than use the full update version, but I'd rather just do defaults correctly and do the thing above.

Nutomic

Sorry i missed the notification somehow, just got a minor note. Thanks for the contribution!

Thor Odinson added 3 commits January 22, 2022 16:25

Initial working of hiding communities and adding a db entry for mod log

c7c6d22

Return mod log for hidden communities

d1e15c7

Clean up hidding communities PR

387eb0f

dayinjing mentioned this pull request Jan 22, 2022

Backend code for hide communities #2032

Closed

use lower case like other migration files

bdee18b

dayinjing commented Jan 23, 2022

View reviewed changes

migrations/2022-01-04-034553_add_hidden_column/up.sql Show resolved Hide resolved

dayinjing commented Jan 23, 2022

View reviewed changes

crates/db_views_actor/src/community_view.rs Show resolved Hide resolved

dayinjing commented Jan 23, 2022

View reviewed changes

crates/db_views_moderator/src/mod_hide_community_view.rs Show resolved Hide resolved

Formatting fix

5fba734

Nutomic mentioned this pull request Jan 28, 2022

Ability for admins to hide communities from the default main feed #2072

Closed

dessalines requested changes Jan 28, 2022

View reviewed changes

pass in admin id to list, make match logic the same in post_view as c…

2ea4a9c

…ommunity_view. Dont force non null for reason

dayinjing requested a review from dessalines January 31, 2022 14:40

dessalines requested changes Jan 31, 2022

View reviewed changes

crates/db_views/src/post_view.rs Outdated Show resolved Hide resolved

crates/db_views/src/comment_view.rs Outdated Show resolved Hide resolved

crates/db_views/src/post_view.rs Outdated Show resolved Hide resolved

Clean PR review stuff

82e3d6f

dayinjing requested a review from dessalines January 31, 2022 23:13

dessalines requested changes Feb 2, 2022

View reviewed changes

migrations/2022-01-04-034553_add_hidden_column/up.sql Outdated Show resolved Hide resolved

migrations/2022-01-04-034553_add_hidden_column/up.sql Show resolved Hide resolved

Change person_id to mod_person_id on hide community table

10ec271

dayinjing requested a review from Nutomic as a code owner February 2, 2022 16:13

dayinjing requested a review from dessalines February 2, 2022 16:14

dessalines requested changes Feb 14, 2022

View reviewed changes

crates/db_schema/src/schema.rs Outdated Show resolved Hide resolved

crates/db_schema/src/source/moderator.rs Outdated Show resolved Hide resolved

Thor Odinson added 2 commits February 14, 2022 13:38

Merge branch 'main' into hide_community_v2

d62b52f

Make bools optional, add a space for formating

9566903

dayinjing requested a review from dessalines February 14, 2022 20:34

dessalines approved these changes Feb 14, 2022

View reviewed changes

Merge branch 'main' into hide_community_v2

d4354fb

Nutomic reviewed Feb 17, 2022

View reviewed changes

Nutomic approved these changes Feb 17, 2022

View reviewed changes

Merge branch 'main' into hide_community_v2

2be8064

dessalines enabled auto-merge (squash) February 18, 2022 02:16

dessalines merged commit 7f9b55e into LemmyNet:main Feb 18, 2022

dayinjing mentioned this pull request Feb 18, 2022

Hide community from trending section #1980

Closed

Neshura87 mentioned this pull request Jun 14, 2023

Add option to hide NSFW communities from "All" feed, while still allowing users to visit NSFW communities and see other NSFW marked posts in non-NSFW communities. LemmyNet/lemmy-ui#1201

Open

Die4Ever mentioned this pull request Jan 22, 2024

UI for instance admins to hide communities from All feed LemmyNet/lemmy-ui#2339

Open

3 tasks

Nutomic mentioned this pull request Mar 13, 2024

Add ability to remove chosen communities from frontpage feed. #4528

Closed

5 tasks

Sjmarf mentioned this pull request Dec 23, 2024

Admin "hide community" action mlemgroup/mlem#1535

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide community v2 #2055

Hide community v2 #2055

dayinjing commented Jan 22, 2022 •

edited

Loading

dessalines left a comment

dayinjing commented Jan 29, 2022 •

edited

Loading

dessalines commented Jan 31, 2022

dayinjing commented Jan 31, 2022

dayinjing commented Feb 2, 2022

dayinjing commented Feb 9, 2022

dayinjing commented Feb 14, 2022

dessalines left a comment

dessalines commented Feb 14, 2022

dessalines commented Feb 17, 2022

Nutomic Feb 17, 2022

dessalines Feb 18, 2022

Nutomic Feb 17, 2022

dessalines Feb 18, 2022

Nutomic left a comment

Hide community v2 #2055

Hide community v2 #2055

Conversation

dayinjing commented Jan 22, 2022 • edited Loading

dessalines left a comment

Choose a reason for hiding this comment

dayinjing commented Jan 29, 2022 • edited Loading

dessalines commented Jan 31, 2022

dayinjing commented Jan 31, 2022

dayinjing commented Feb 2, 2022

dayinjing commented Feb 9, 2022

dayinjing commented Feb 14, 2022

dessalines left a comment

Choose a reason for hiding this comment

dessalines commented Feb 14, 2022

dessalines commented Feb 17, 2022

Nutomic Feb 17, 2022

Choose a reason for hiding this comment

dessalines Feb 18, 2022

Choose a reason for hiding this comment

Nutomic Feb 17, 2022

Choose a reason for hiding this comment

dessalines Feb 18, 2022

Choose a reason for hiding this comment

Nutomic left a comment

Choose a reason for hiding this comment

dayinjing commented Jan 22, 2022 •

edited

Loading

dayinjing commented Jan 29, 2022 •

edited

Loading