Optimize actor_language.rs #4612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dullbananas
commented
Apr 9, 2024
| convert_read_languages(conn, langs).await | ||
| }) as _ | ||
| }) | ||
| .await |
There was a problem hiding this comment.
This transaction was added in #2510 and appears to be a mistake
Nutomic
approved these changes
Apr 25, 2024
Nutomic
reviewed
Apr 25, 2024
|
|
||
| let forms = lang_ids | ||
| .into_iter() | ||
| .iter() |
There was a problem hiding this comment.
Looks like these changes break the tests, and anyway that was fine. The rest looks very good.
There was a problem hiding this comment.
I now tried to fix the type mismatch error.
This change is needed to satisfy the borrow checker.
dullbananas
requested review from
SleeplessOne1917,
dessalines and
phiresky
as code owners
SleeplessOne1917
approved these changes
Apr 27, 2024
dessalines
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipelining: https://docs.rs/diesel-async/latest/diesel_async/pg/struct.AsyncPgConnection.html
Some changes to statements are to prevent the execution order of pipelined statements from making a difference