Remove architecture_independent from leo_msgs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ROS 1, message packages did not create any binaries and were therefore architecture-independent packages. In ROS 2, static typesupport results in library creation whenever messages are generated, which are not architecture-independent.
|
Note that this PR is against the default branch of this repository, but the fix will be needed in |
|
Thanks for the quick reaction. I was not aware about that (I'm still new to ROS2). I'll release the new version with this change to btw. the buildfarm did not send any email about the failing job to the package maintainer. I don't know if that is the intended behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ROS 1, message packages did not create any binaries and were therefore architecture-independent packages.
In ROS 2, static typesupport results in library creation whenever messages are generated, which are not architecture-independent.
This should resolve the current build failure for building this package for RHEL: https://build.ros2.org/job/Hbin_rhel_el864__leo_msgs__rhel_8_x86_64__binary/