New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Build.PL #3

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@genehack
Contributor

genehack commented Jan 30, 2015

Removes the broken Build.PL and adds a README file explaining basic dzil usage.

I considered adding in dzil config to copy the generated Build.PL out of the .build directory, but that seemed more invasive. If you'd prefer that, I'm happy to revise this. Chrs.

(Part of the CPAN PR challenge.)

@Leont

This comment has been minimized.

Show comment
Hide comment
@Leont

Leont Jan 30, 2015

Owner

Removes the broken Build.PL

It's not so much broken, however it is a bit counter-intuitive. It's a template, not something intended to be used directly (though it's sort of functional by itself). It's needed to work around linking issues on Windows and Solaris. As such, I can't get rid of it that easily.

I'd love to have better infrastructure, but that would probably require a ModuleBuild::Awesome similar to MakeMaker::Awesome. That'd be a somewhat non-trivial project. Possibly I could convert to MakeMaker::Awesome, but most of the complicity is inherent not accidental.

I considered adding in dzil config to copy the generated Build.PL out of the .build directory, but that seemed more invasive.

It would be tricky to make it work right, and that sort of thing is generally not my preferred kind of workflow.

and adds a README file explaining basic dzil usage.

Looks ok to me. Possibly it should be filtered out of the dist when the final product is being built (and it's currently only partially formatted).

(Part of the CPAN PR challenge.)

I was wondering if I would get a PR out of it :-). You had a though one assigned to you.

Owner

Leont commented Jan 30, 2015

Removes the broken Build.PL

It's not so much broken, however it is a bit counter-intuitive. It's a template, not something intended to be used directly (though it's sort of functional by itself). It's needed to work around linking issues on Windows and Solaris. As such, I can't get rid of it that easily.

I'd love to have better infrastructure, but that would probably require a ModuleBuild::Awesome similar to MakeMaker::Awesome. That'd be a somewhat non-trivial project. Possibly I could convert to MakeMaker::Awesome, but most of the complicity is inherent not accidental.

I considered adding in dzil config to copy the generated Build.PL out of the .build directory, but that seemed more invasive.

It would be tricky to make it work right, and that sort of thing is generally not my preferred kind of workflow.

and adds a README file explaining basic dzil usage.

Looks ok to me. Possibly it should be filtered out of the dist when the final product is being built (and it's currently only partially formatted).

(Part of the CPAN PR challenge.)

I was wondering if I would get a PR out of it :-). You had a though one assigned to you.

@genehack

This comment has been minimized.

Show comment
Hide comment
@genehack

genehack Feb 3, 2015

Contributor

Okay, shortly I'll force-push an update to this branch that doesn't remove Build.PL but updates the README to clarify that the Build.PL file is a template and shouldn't be used. I'll also update the dist.ini to not copy the README into the build (and fixes the bad formatting)

Contributor

genehack commented Feb 3, 2015

Okay, shortly I'll force-push an update to this branch that doesn't remove Build.PL but updates the README to clarify that the Build.PL file is a template and shouldn't be used. I'll also update the dist.ini to not copy the README into the build (and fixes the bad formatting)

@genehack

This comment has been minimized.

Show comment
Hide comment
@genehack

genehack Mar 2, 2015

Contributor

Okay, I have pushed a revised set of changes:

  • Don't remove Build.PL
  • Update README.md to explain Build.PL
  • Update dist.ini to not copy README.md into the built dist
  • Fix formatting in README.md
Contributor

genehack commented Mar 2, 2015

Okay, I have pushed a revised set of changes:

  • Don't remove Build.PL
  • Update README.md to explain Build.PL
  • Update dist.ini to not copy README.md into the built dist
  • Fix formatting in README.md

@Leont Leont self-assigned this Mar 13, 2018

@Leont

This comment has been minimized.

Show comment
Hide comment
@Leont

Leont Apr 4, 2018

Owner

Merged this as part of 0.017

Owner

Leont commented Apr 4, 2018

Merged this as part of 0.017

@Leont Leont closed this Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment