Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Aug 29, 2011
  1. @lshepard

    Remove auth.expireSession call from SDK

    lshepard committed
    Summary: The expireSession call was put in as a precaution to make sure that
    apps sessions were really no longer good. However, this is unnecessary and it
    causes issues with apps that were expecting the session to remain usable even
    after the user logged out. So let's remove this call and leave it up to the app
    developer to expire the session if they want.
    Test Plan: Logged in and out of the demo app.
    Reviewed By: trvish
Commits on Aug 26, 2011
  1. README changes only - Documentation update to match init session dele…

    Christine Abernathy committed
    …gate changes. Add notice on issue reporting.
Commits on Aug 15, 2011
  1. @raghuc

    Refactor to init session delegate in Facebook.m constructor

    raghuc committed
    Summary: The change basically just sets the session delegate in the constructor so
    it's available when handleOpenUrl is called.
    Test Plan: Ran the DemoApp and ensured SSO still works.
    Reviewed By: toddkrabach
    Reviewers: seshadri, leon, atishm, toddkrabach, lshepard, caabernathy
    Differential Revision: 297414
    Task ID: 653835
Commits on May 27, 2011
  1. @seshness

    Use the Graph API for the photo uploading example.

    seshness committed
    Edited uploadPhoto to use requestWithGraphPath instead of the legacy REST api
    requestWithMethodName method. Also added the publish_stream permission, which
    needed for uploading photos.
    Test Plan:
    Run the DemoApp and login. Click the upload button and verify that a photo was
    uploaded to the user's Facebook account (pending approval).
    Reviewed By: yariv
    Reviewers: yariv
    CC: yariv
    Differential Revision: 257551
Commits on May 17, 2011
  1. @yariv

    a couple of small cleanups

    yariv committed
  2. @yariv

    small comment fix

    yariv committed
  3. @yariv

    Add the 'localAppId' param to [Facebook authorize]

    yariv committed
    This is the SDK diff to support the local_client_id URL parameter that we added
    to the FB app. I named it 'localAppId' to be consistent with the 'appId'
    parameter to the same function.
    Test Plan:
    bound the demo app to 'fb1234foo' and passed 'foo' as the localAppId value.
    verified the SDK used the 'fbauth2' url scheme to open the fb app and that the
    fb app successfully redirected back to the demo app.
    Reviewed By: brent
    Reviewers: lshepard, atishm, brent, oyamauchi, jimbru
    CC: brent
    Differential Revision: 211201
Commits on Apr 6, 2011
  1. @caabernathy
Commits on Jan 31, 2011
  1. Return FBRequest* from request: methods.

    Jim Brusstar committed
    The request: selectors in the Facebook class now return a pointer to the
    instantiated FBRequest object (rather than void). This makes it easier
    to know in the delegate callback which request the callback maps to.
Commits on Dec 14, 2010
  1. @bgold

    fixing docs link

    bgold committed
Commits on Dec 8, 2010
  1. Updates to README for platform dialogs.

    Jim Brusstar committed
  2. Add app_id to dialog requests.

    Jim Brusstar committed
    Updated the dialog() method to always include app_id. This will prevent
    an error if a dialog is requested and the application doesn't have an
    access token. App_id must now be specified in the Facebook constructor
    as this saves specifying it with every request. Xcode project has been
    updated to build with iOS SDK 4.3.
Commits on Dec 2, 2010
  1. Platform Dialogs Support (UIServer Pretty URLs)

    Jim Brusstar committed
Commits on Dec 1, 2010
  1. @bgold

    added an anchor to dialogs

    bgold committed
Commits on Nov 30, 2010
  1. @yariv

    Prevent dismissWithSuccess:animated from being called twice

    yariv committed with Yariv Sadan
    Test Plan:
    verified it was called only once
    DiffCamp Revision: 186903
    Reviewed By: brent
    CC: brent
    Revert Plan:
Commits on Nov 23, 2010
  1. @mvernal

    Adding note about plist

    mvernal committed
  2. @mvernal

    Clarifying start instructions

    mvernal committed
Commits on Nov 11, 2010
  1. fix the readme formatting

    Yariv Sadan committed
Commits on Nov 9, 2010
  1. Fix the way the SDK interprets UIWebViewDelegate errors

    Yariv Sadan committed with Yariv Sadan
    Currently if the facebook app encounters a UIWebViewDelegate error, it passes
    it to the sdk in the error_code parameter. The SDK should know that if this
    parameter is passed, an error occurred, which implies the user *didn't* cancel.
    This fixes it.
    Test Plan:
    disconnected my laptop from the internet, went through the sso flow, verified
    the sdk set userDidCancel to NO before calling [self
    DiffCamp Revision: 180310
    Reviewed By: brent
    CC: brent
    Revert Plan:
Commits on Nov 8, 2010
  1. Updates to README.

    Jim Brusstar committed
    Edits to the documentation for clarity and grammar. This brings
    documentation more in line with Android SDK for consistency.
    arunv, brent, lshepard
    Test Plan:
    All comments--no impact on code.
    DiffCamp Revision: 179248
Commits on Nov 5, 2010
  1. Removing theRunAround Sample App.

    Jim Brusstar committed
    It wasn't particularly useful, so it gets the rm -rf.
    Test Plan:
    Nothing depended on this, so we're good.
    DiffCamp Revision: 179177
    Reviewed By: yariv
    CC: arunv, lshepard, brent, rmcelroy, arice, achao, yariv, bootcamp-diffs@lists
    #431037: Go start-to-finish through iOS SDK and validate
    Revert Plan:
  2. Make theRunAround use SSO

    Yariv Sadan committed with Yariv Sadan
    Summary: n/a
    Task ID: #
    Blame Rev:
    Reviewers: brent, jbrusstar, lshepard, arunv
    Test Plan: verified login via SSO worked
    Revert Plan:
    - begin *PUBLIC* platform impact section -
    Bugzilla: #
    - end platform impact -
    DiffCamp Revision: 179100
  3. iOS single sign on

    Yariv Sadan committed
    This diff implements single sign-on for iOS.
    Test Plan:
    DiffCamp Revision: 179082
    Reviewed By: brent
    CC: brent, arice, yariv
    Revert Plan:
Commits on Oct 14, 2010
  1. iOS SDK sample app 'theRunAround' modified to only show friends using…

    Vikas Gupta committed
    … the app.
    The app before showed all your friends regardless of if they were using this
    With this diff, only friends who are or have used the app will be shown in the
    Test Plan:
    Run the app with an app id which only some of your friends are using and only
    those friends should show in the friends list.
    DiffCamp Revision: 169803
    Reviewed By: brent
    CC: brent
    Revert Plan:
Commits on Sep 23, 2010
  1. iOS SDK: fix memory issue in SDK and theRunAround demo App

    Yujuan Bao committed
    Fix some memory leak and dealloc issues
    The Facebook.m -logout: method calls this:
    [self requestWithMethodName:@"auth.expireSession"
    andParams:params andHttpMethod:@"GET"
    By setting the Facebook object as the delegate, it gets retained by the FBRequest object, but in turn the -openUrl:params:httpMethod:delegate: method retains the request itself in the _request instance variable. This creates a retain cycle, and neither object will be freed.
    -in Session.m, there is a missing retain on the uid in -restore -in Session.m there is no dealloc method — one should be added to free facebook and uid -in UserInfo.m, the dealloc needs to release the userInfoDelegate that was retained -in UserRequestResult.m there is no dealloc — one should be added to free userRequestDelegate
    test plan:
    theRunAroundDemoApp, open the app login and turn off the app without log out. bring the app up again. make sure we are logged in and all the session info bring back correctly.
    Run the unittest
Commits on Sep 20, 2010
Commits on Sep 13, 2010
  1. iOS SDK: fix a few issues

    Yujuan Bao committed
Commits on Sep 9, 2010
  1. iOS SDK: Use the new set of button image

    Yujuan Bao committed
Commits on Sep 1, 2010
  1. iOS SDK:Facebook delegate fbDidNotLogin add a parameter to check if u…

    Yujuan Bao committed
    …ser cancel and address several other issue
Commits on Aug 26, 2010
Commits on Aug 25, 2010
  1. ios sdk: remove an extra retain and a warning msg

    Yujuan Bao committed
Commits on Aug 20, 2010
Commits on Aug 19, 2010
  1. ios sdk :a fix on url encode at FBRequest.m

    Yujuan Bao committed
Commits on Aug 17, 2010
  1. iOS sdk : clean up some mess around the README file

    Yujuan Bao committed
Commits on Aug 16, 2010
Something went wrong with that request. Please try again.