Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upallow empty value in batch #48
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
fyi, the two failing tests were already failing before this pr |
juliangruber
merged commit e6a9821
into
master
May 28, 2016
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
juliangruber
deleted the
allow-empty-value-in-batch
branch
May 28, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
nolanlawson
May 30, 2016
Member
This really ought to have tests to check the new behavior, but I understand the existing tests are already failing. I'll look into this.
|
This really ought to have tests to check the new behavior, but I understand the existing tests are already failing. I'll look into this. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
I'll open another PR with some tests. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mafintosh commentedMay 28, 2016
This PR allows for empty values in batches. Regular leveldown supports this and this is already supported using
.put.