This workflow governs code changes across the project
- Create your own working branch of the repository
- Pick a piece of work out of the backlog
- Do the work against your working branch
- Push the working branch to GitHub
- Open a Pull Request against the main working branch
- Teammate reviews the PR
- If review approved, teammate merges PR
- If changes requested, return to step 3
All work needing to be done should have an associated GitHub issue. Every issue must be labeled with one of each of the following types of label:
- component: What component of the project is this work being done for
- type: What type of issue is it
- status: What is the current status of this work
- front end: The browser application for consuming the API
- api: The public interface for exploring and analyzing data
- database: The organizational and relational design of the data itself
- pipeline: The scripts which automate addition of new data to the database
- documentation: Creation of instructional material which makes the project usable
- data analysis: Data sciency stuff around doing black magic with the data
Work status workflow
ready ──────────────────────┐ ↓ │ in progress ←→ blocked ─────┤ ↓↑ │ awaiting review ────────────┤ ↓ ↓ completed abandoned
Work status definitions
- ready: This issue is ready to be worked.
- in progress: This issue is being worked on. Issues in this status must have an assignee
- blocked: Work on this issue cannot be completed until some other piece of work is completed. When placing an issue into this state, a comment must be added to the ticket describing the blocker, providing links whenever possible.
- awaiting review: Work on this issue is completed and awaiting peer review. In this state, the issue must either have no assignee or be assigned to the teammate responsible for performing the review. When placing an issue into this state, a comment must be added to the ticket describing how a reviewer can retrieve and review the work. Links to PRs/commits are ideal.
- completed: The reviewer has approved of the work and it has been merged. The reviewer is responsible for merging the work, closing the issue, and applying the "completed" tag to the closed issue.
- abandoned: Work on this issue cannot or will not be completed. The team member closing the issue is responsible for applying this tag.
Bug status workflow
Bugs have an additional status flow which exists alongside the work status flow:
reported ─────────┬───────────┐ ↓ ↓ ↓ reproduced ← needs info → is a feature
What's important to note is in addition to always having a work status tag (as tasks do), bugs will also always have a bug status tag. Each status tag serves a different purpose.
Bug status definitions
- reported: When an issue is opened with a report of an alleged bug, it is placed in this status
- needs info: The team member working to reproduce the issue needs additional information to do so
- reproduced: The bug has been successfully reproduced by another team member
- is a feature: The reported bug is not actually a bug
Bug workflow notes
- Any issue which has a bug status tag of "reported" or "needs info" must have a work status tag of "blocked".
- When a bug is placed into status "reproduced", it should be assigned a work status tag of "ready" and proceed through the regular task flow.
- When a bug is placed into status "is a feature" it should be assigned a work status tag of "abandoned" and the issue should be closed.