-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement positional-only arguments #14
Conversation
|
Ooo… nice! I will go through this over the next few days. We just finished long weekend in Poland (1st and 3rd were national holidays) and things have piled up. I will also respond on the Swift forum. |
|
I wish you had a nice holiday! |
|
Finished the review and for me it is ready for merge. My changes:
|
|
Can I merge or there is something more to do? |
|
wow, I didn't know I missed these many things. putting |
|
You only missed I wrote unit tests by hand, because I like be able to put a breakpoint and stop there in a few seconds (I once worked on a project in which the time between writing code and debugging was measured in minutes…). In general, I to try to exercise at least the main path, so that I know the runtime actually can get there. But unit tests are a 'bonus' feature. And, yes I really need to work on the CI thing for Violet. Putting |
https://peps.python.org/pep-0570/
I know Violet is targeting Python 3.7 for now, but this is required to catch up the upper version later.