Fix use-after-free and concurrent access segmentation fault #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and the clientOutput thread
|
Thanks! Will review ASAP, time permitting. |
rgacogne
reviewed
Nov 28, 2018
libvncserver/main.c
Outdated
| if(cl->screen->backgroundLoop) | ||
| pthread_create(&cl->client_thread, NULL, clientInput, (void *)cl); | ||
| if(cl->screen->backgroundLoop) { | ||
| pipe(cl->pipe_notify_client_thread); |
There was a problem hiding this comment.
It might be nice to check the return value of pipe(), and perhaps set cl->pipe_notify_client_thread[0] and cl->pipe_notify_client_thread[1] to -1 if it fails? Because the current code will try to read and write from arbitrary file descriptors, and will also end up closing them, if pipe() failed.
There was a problem hiding this comment.
I will change that ASAP. Thanks for the review and sorry for the delay.
This was referenced Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientOutputthat will access it.See #212 for more informations.
PS: It's really hard to make a tiny PR because of the indentation issues everywhere, you should probably do something about that :)