Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed Buffer Overflow Issue #94
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
Also, please make sure to squash your commits :-) |
This comment has been minimized.
This comment has been minimized.
|
Closing in favour of 4791d1e. Nonetheless, you contributions is valued! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
raminfp commentedApr 2, 2019
•
edited
Hi,
Description
We see char sun_path[UNIX_PATH_MAX]; /* pathname */ of sockaddr_un that UNIX_PATH_MAX=108
Overflow code
strcpy(saun.sun_path, file);There isn't any check if length file greater of length saun.sun_path
Thanks,
Ramin - Saminray Security Researcher Team (SSRT)