Skip to content

Bounds checking for shapes in GUI #436

Open

Description

@uellue

How to reproduce:

Open a file and add an analysis that has GUI control elements. Use keyboard controls to adjust the size.

Observed behavior:

  1. When reducing an inner radius, the value doesn't reach zero, but starts cycling between an arbitrary x and (stepsize-x).
  2. The outer radius can be increased without apparent limit

Expected behavior:

  1. The inner radius goes to zero with the last step that is smaller than the step size and remains zero when trying to reduce it further
  2. The outer radius is limited by the diagonal of the control.

Activity

  1. sayandip18 commented on Apr 8, 2020

    @sayandip18
    Contributor

    I have managed to reproduce this. What are the prerequisites for this issue?

  2. sk1p commented on Apr 16, 2020

    @sk1p
    Member

    @sayandip18 this is mostly an issue that can be solved if you know a bit of TypeScript. The draggable handles all have some kinds of constraints applied already, so this issue should be fixable by changing those constraints.

    Related: on a data set that is has a 1 for one of the navigation axes, the frame picking mode errs out - I think the default values need to be fixed there.

  3. added a commit that references this issue on Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions