Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build universal wheels #109

Merged
merged 1 commit into from Jun 15, 2018
Merged

Build universal wheels #109

merged 1 commit into from Jun 15, 2018

Conversation

@nsoranzo
Copy link
Contributor

@nsoranzo nsoranzo commented Jun 15, 2018

See https://packaging.python.org/guides/distributing-packages-using-setuptools/#universal-wheels

@coveralls
Copy link

@coveralls coveralls commented Jun 15, 2018

Coverage Status

Coverage remained the same at 83.211% when pulling 71ac38b on nsoranzo:patch-1 into 0dfc970 on LibraryOfCongress:master.

Loading

@acdha
Copy link
Member

@acdha acdha commented Jun 15, 2018

I'm really inclined to drop Python 2.6 support since it's been deprecated by the core Python development team since 2013. I'll merge this PR but we should update the docs as well.

Loading

@acdha acdha merged commit c2aedef into LibraryOfCongress:master Jun 15, 2018
1 of 2 checks passed
Loading
@johnscancella
Copy link
Contributor

@johnscancella johnscancella commented Jun 15, 2018

@acdha I have yet to be on a system that required me to use python 2.6(and you know we work on some old kernels). Any reason to not drop it now?

Loading

@nsoranzo nsoranzo deleted the patch-1 branch Jun 15, 2018
@nsoranzo
Copy link
Contributor Author

@nsoranzo nsoranzo commented Jun 15, 2018

@acdha Thanks for the merge!

That's needed anyway to support Python 2.7 and 3.x with the same wheel.

Loading

@acdha
Copy link
Member

@acdha acdha commented Jun 15, 2018

See #110 for the Python 2.6 removal.

Loading

@nsoranzo
Copy link
Contributor Author

@nsoranzo nsoranzo commented Jun 15, 2018

Also, it could be pretty cool if you could provide wheels on PyPI for the next releases!

Loading

@acdha
Copy link
Member

@acdha acdha commented Jun 15, 2018

Will do!

Loading

@acdha
Copy link
Member

@acdha acdha commented Jun 26, 2018

https://pypi.org/project/bagit/ has 1.7.0 with wheels. Since it dropped Python 2.6 support I figured it was more than a point release.

Loading

@nsoranzo
Copy link
Contributor Author

@nsoranzo nsoranzo commented Jun 26, 2018

Thanks a lot!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants