spline optimization #360

Open
markvdb opened this Issue Jan 21, 2013 · 8 comments

Projects

None yet

3 participants

@markvdb
markvdb commented Jan 21, 2013

(I just mistakenly submitted this bug to sf.net. Sorry about the double reporting.)

This makes librecad choke:
http://glasno.st/ugis/prototype.dxf

librecad 1.0.1+nolibs-2dailynatty1
libdxf lib 2.2.0.0-8daily8natty1

Is there anything I can do?

P.S. Thank you for your work on Librecad!

@Rallaz
Contributor
Rallaz commented Jan 22, 2013

You are using an old LC version. The last stable version in 1.0.2
or update to daily-builds (2.0.0 beta1)
At this moment I can´t test your dxf in LC1.x but in 2series it works.

dxflib are a old & unmantained library that support dxf 12 & 2000, your dxf is 2007
LC 2 series uses libdxfrw (in LC source code) more modern and mantained.
I recommend you to upgrade to daily-builds

If you get open, you will find a problem, LC will be slow because the use of splines need further optimization and your drawing is made with a program that converts all to splines (exactly 149 splines)

@Rallaz
Contributor
Rallaz commented Jan 22, 2013

Attached a screenshot of your file
prototype

@markvdb
markvdb commented Jan 22, 2013

Sorry I hadn't checked the dev branch. Thx for the hint!

Feel free to merge this into a spline optimisation bug. You'll know best yourself how to organise that...

@r-a-v-a-s r-a-v-a-s closed this Aug 9, 2015
@markvdb
markvdb commented Aug 10, 2015

The spline optimisation is still absent from LibreCAD 2.0.4 (the most recent Debian packaged version).

I haven't rebuilt librecad from the latest git source yet, but I have checked the current issues list (no mention of spline optimisation), and I do not see any reference to a fix, so I would really like to see this issue reopened...

@r-a-v-a-s r-a-v-a-s reopened this Aug 10, 2015
@r-a-v-a-s r-a-v-a-s added request and removed import error labels Aug 10, 2015
@r-a-v-a-s r-a-v-a-s changed the title from Librecad chokes on this open hardware dxf file to spline optimization Jun 21, 2016
@r-a-v-a-s
Member

The file has almost 900,000 entities 😲

I'm going to try make some optimizations... but that's simply a ton of entities that need processing.

The first thing I can do is make it only draw the bounding boxes while panning.
I've done it for text; and I've already tried it for splines, and your drawing pans at high speeds...
Is it too visually disruptive to do this for splines?

@markvdb
markvdb commented Jun 21, 2016

Thank you for your good work on this. Much appreciated!

@r-a-v-a-s r-a-v-a-s added weakness and removed request labels Jun 21, 2016
@r-a-v-a-s
Member

I've noticed your circles are actually splines,
and each one is 8k entities!

I'm curious, were you using a circle tool in another program?
Or did you purposefully use a spline tool to create the circles?
Converting them would definitely help.

@markvdb
markvdb commented Jun 21, 2016

This was created in a non-free piece of software that I have no access to.
Corel Draw even originally, if I'm not mistaken. Being able to use the dxf
export in LibreCad is somewhat of a corner case, but a useful one I hope...

2016-06-21 21:53 GMT+02:00 ravas notifications@github.com:

I've noticed your circles are actually splines,
and each one is 8k entities!

I'm curious, were you using a circle tool in another program?
Or did you purposefully use a spline tool to create the circles?
Converting them would definitely help.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#360 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAviCLBfmTCYRBIGp0SEDzJewND66qoWks5qOEEfgaJpZM4AYBzD
.

Mark Van den Borre
Hogestraat 16
3000 Leuven, België
+32 486 961726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment