Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With "open" menu option - always empty DXFs #978

Open
CED34 opened this issue May 1, 2018 · 3 comments

Comments

@CED34
Copy link

commented May 1, 2018

Expected behavior

See drawing when i open a DXF. :)

Observed behavior

Empty drawing on DXF load.
I had same problem with 2.1.3, so i updated, but same issue with last version.

When I open librecad and use open in the menu, i have an empty drawing. (autozoom tried ;) ).
Note that in this case, it seems to see modifications as it asks me to save before exiting...

When I open a DXF (made by librecad) by double click on explorer, it works.
When I open using recent files, it works.
I will use this last option to be able to open 2 files in the same instance for copy-paste purpose.

Steps to reproduce or sample file

Using open menu option on a DXF file (not tried on other file types).
I use http://forum.librecad.org/file/n5713719/test2.dxf has testing file to be sure it's not my-files related.

Operating System and LibreCAD version info

OS: Windows 10 64bits home (french)
IntelCore I5-4570 (4 cores)
Mem 16Go

LibreCad:
Version: 2.2.0-rc1
Compiler: GNU GCC 4.9.1
Compiled on: Feb 16 2018
Qt Version: 5.4.1
Boost Version: 1.53.0
System: Windows

@Knaldgas

This comment has been minimized.

Copy link

commented Jun 28, 2018

Confirmed

Version: 2.1.3
Compiler: GNU GCC 7.3.0
Compiled on: Mar 24 2018
Qt Version: 5.10.1
Boost Version: 1.62.0
System: Debian GNU/Linux buster/sid

@lordofbikes

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

By accident I found this:
grafik
The default for Files of type is Drawing Exchange (*.dxf).
With Drawing Exchange type files open well, but not with QCad 1.x file!
The Files of type selection is stored in settings, so when the type in open file dialog was changed by accident, empty drawings are the result.
Using recent files list, the type detection returns Drawing Exchange and the file opens well.

I can't say yet, why QCad 1.x files results in an empty drawing.
We have to check if QCad 1.x was that different or if there is an issue with this import filter.

@shawncurry

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Looking at rs_filterdxf1.cpp, the import code appears to be ported from qcad (and it's a mess), and the export was never implemented. Perhaps some heuristics could be identified in order to assist in correctly identifying DXFs that use the nonstandard QCAD format. QCAD 1.x examples would need to be located for inspection and testing in order to implement this.

I recommend discontinuing this feature. It would be of limited value even if implemented, and qcad must already support such a conversion anyhow if it was ever needed.

If the file is opened as "Drawing Exchange (*.dxf)", it opens properly:
test2dxf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.