Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL Rendering Implemented #229

Merged
merged 103 commits into from
Aug 30, 2019
Merged

OpenGL Rendering Implemented #229

merged 103 commits into from
Aug 30, 2019

Conversation

sckorpio
Copy link
Contributor

Finished the OpenGL Rendering module!!!

@sckorpio sckorpio closed this Aug 23, 2019
@sckorpio sckorpio reopened this Aug 23, 2019
Copy link
Member

@feragon feragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much better, but some work is still needed

lcviewernoqt/CMakeLists.txt Outdated Show resolved Hide resolved
lcUI/CMakeLists.txt Outdated Show resolved Hide resolved
lcUI/lcadviewer.cpp Outdated Show resolved Hide resolved
lcUI/lcadviewer.cpp Outdated Show resolved Hide resolved
lcviewernoqt/painters/opengl/sources/gl_font.cpp Outdated Show resolved Hide resolved
lcviewernoqt/painters/openglpainter.cpp Outdated Show resolved Hide resolved
lcviewernoqt/viewersettings.h Outdated Show resolved Hide resolved
@sckorpio sckorpio closed this Aug 24, 2019
@sckorpio sckorpio reopened this Aug 24, 2019
Copy link
Member

@feragon feragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better, but there are still some places where you left commented code and code duplication.

The fonts are still present in the PR, which means it can't be accepted because we can't redistribute those due the licenses

lcUI/lcadviewer.cpp Outdated Show resolved Hide resolved
lcUI/lcadviewer.cpp Outdated Show resolved Hide resolved
lcUI/lcadviewer.cpp Outdated Show resolved Hide resolved
lcUI/lcadviewer.h Outdated Show resolved Hide resolved
lcUI/lcadviewer.h Outdated Show resolved Hide resolved
lcviewernoqt/painters/opengl/sources/shader.cpp Outdated Show resolved Hide resolved
lcviewernoqt/painters/opengl/sources/shader.cpp Outdated Show resolved Hide resolved
lcviewernoqt/painters/opengl/sources/text_entity.cpp Outdated Show resolved Hide resolved
lcviewernoqt/painters/opengl/sources/shape_entity.cpp Outdated Show resolved Hide resolved
lcviewernoqt/painters/opengl/sources/shape_entity.cpp Outdated Show resolved Hide resolved
Copy link
Member

@feragon feragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 things left:

  • Lower the OpenGL required version (3.0 would be good, unless you need a specific function from a newer API)
  • There is still one occurrence of commented code
  • You need to delete the two fonts that we can't redistribute

@@ -28,7 +28,7 @@ LCADViewer::LCADViewer(QWidget *parent) :

QSurfaceFormat format;
format.setMajorVersion(4);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OpenGL, 3.0 means :
Major version: 3
Minor version: 0

@feragon feragon changed the base branch from master to opengl August 30, 2019 10:01
@feragon feragon merged commit ebbf7b9 into LibreCAD:opengl Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants